cloudposse / terraform-aws-dynamic-subnets

Terraform module for public and private subnets provisioning in existing VPC
https://cloudposse.com/accelerate
Apache License 2.0
191 stars 165 forks source link

Feat/ipv6 #139

Closed marekmoscichowski closed 2 years ago

marekmoscichowski commented 3 years ago

what

why

references

closes #21

mergify[bot] commented 3 years ago

This pull request is now in conflict. Could you fix it @marekmoscichowski? 🙏

justnom commented 2 years ago

Is there anymore work that needs to be done to this?

The new version might break dependant modules as it has a hard requirement for the egress_only_igw_id input.

mihaiplesa commented 2 years ago

@marekmoscichowski is this still maintained by you?

carsondoesbusiness commented 2 years ago

Any plans to merge this soon? Really need this feature!

aknysh commented 2 years ago

@marekmoscichowski please address the comments by @nitrocode

marekmoscichowski commented 2 years ago

Hi, @aknysh @mihaiplesa

unfortunately, I've got a lot on my plate atm. But I saw that there is a similar pr opened quite recently which might be currently maintained https://github.com/cloudposse/terraform-aws-dynamic-subnets/pull/147

amexboy commented 2 years ago

@marekmoscichowski if you could add me as a writer on your repository I could maintain this PR! I think it would be faster than requesting a new review!