tfsec ignores added/fixed

cloudposse / terraform-aws-dynamic-subnets

Terraform module for public and private subnets provisioning in existing VPC

https://cloudposse.com/accelerate

Apache License 2.0

191 stars 165 forks source link

tfsec ignores added/fixed #177

Closed davenicoll closed 1 year ago

davenicoll commented 1 year ago

what

Changed tfsec ignore comments to use the rule name, rather than deprecated IDs
Added ignores to public and private so that tfsec passes the module without CRITICAL issues

why

tfsec no longer supports #tfsec:ignore:AWS012 style comments
False positives generated by this module have been ignored

jamengual commented 1 year ago

/test all

jamengual commented 1 year ago

@max-lobur is there anything @davenicoll or me needs to do to fix this? reviewdog: This GitHub token doesn't have write permission of Review API [1], so reviewdog will report results via logging command [2] and create annotations similar to

max-lobur commented 1 year ago

@max-lobur is there anything @davenicoll or me needs to do to fix this? reviewdog: This GitHub token doesn't have write permission of Review API [1], so reviewdog will report results via logging command [2] and create annotations similar to

This is expected for forks. But the original tflint complaint looks weird though

max-lobur commented 1 year ago

This should fix it https://github.com/cloudposse/terraform-aws-dynamic-subnets/pull/180

max-lobur commented 1 year ago

/terratest