cloudposse / terraform-aws-ec2-client-vpn

https://cloudposse.com/accelerate
Apache License 2.0
45 stars 28 forks source link

Fix bug if we disable creation of security group #48

Closed nyf-nyf closed 2 years ago

nyf-nyf commented 2 years ago

what

why

references

nyf-nyf commented 2 years ago

The bug appeared, when we tried to disable the creation of security group and created it by ourselves. Then passed the id of the created security group to the input var "associated_security_group_ids". In this case the first argument in concat appears to be null.

Zeskbest commented 2 years ago

@nitrocode approve please, we dont want to create 13th fork =3

nitrocode commented 2 years ago

@nyf-nyf @Zeskbest please see comment

Zeskbest commented 2 years ago

@nitrocode Hi there! Do we need any more updates? =)

nyf-nyf commented 2 years ago

@nitrocode check please

aknysh commented 2 years ago

/test all