cloudposse / terraform-aws-ec2-client-vpn

https://cloudposse.com/accelerate
Apache License 2.0
45 stars 28 forks source link

Use sg ids argument, rm deprecated input #51

Closed nitrocode closed 1 year ago

nitrocode commented 2 years ago

what

why

│ Warning: Argument is deprecated
│
│   with module.ec2_client_vpn.aws_ec2_client_vpn_network_association.default,
│   on .terraform/modules/ec2_client_vpn/main.tf line 228, in resource "aws_ec2_client_vpn_network_association" "default":
│  228:   security_groups = compact(concat(
│  229:     [module.vpn_security_group.id],
│  230:     local.associated_security_group_ids
│  231:   ))
│
│ Use the `security_group_ids` attribute of the `aws_ec2_client_vpn_endpoint` resource instead.
│
│ (and one more similar warning elsewhere)

references

nitrocode commented 2 years ago

/test all

joe-niland commented 1 year ago

@nitrocode I just merged #53 but I didn't see your very similar PR, sorry.