cloudposse / terraform-aws-ec2-client-vpn

https://cloudposse.com/accelerate
Apache License 2.0
45 stars 28 forks source link

Add support for transport_protocol variable in aws_ec2_client_vpn_endpoint #61

Closed s1rc closed 1 year ago

s1rc commented 1 year ago

what

The aws_ec2_client_vpn_endpoint supports variables for defining the transport_protocol as tcp or udp. Without adding this variable to this module, it will always default to udp.

why

To be able to add tcp as a transport_protocol for Client VPN Endpoints in Terraform as you would be able to configure in the AWS console.

references

joe-niland commented 1 year ago

@s1rc thank you for the PR.

Could you please run the following locally and commit the result?

make init
make github/init
make readme

It will update the GitHub workflows to the latest versions and update the README.

s1rc commented 1 year ago

@joe-niland I ran those commands, on make readme it is failing with output below. This is my first time contributing with your build harness, not sure what I can do to successfully run the command.

❯ make readme
* Installing packages master...
Cloning into '/Users/Matt/Development/Terraform/terraform-aws-ec2-client-vpn/build-harness/vendor/packages'...
remote: Enumerating objects: 914, done.
remote: Counting objects: 100% (914/914), done.
remote: Compressing objects: 100% (452/452), done.
remote: Total 914 (delta 326), reused 576 (delta 227), pack-reused 0
Receiving objects: 100% (914/914), 7.88 MiB | 8.39 MiB/s, done.
Resolving deltas: 100% (326/326), done.
* Installing gomplate to /Users/Matt/Development/Terraform/terraform-aws-ec2-client-vpn/build-harness/vendor
mkdir -p -m a+rX /Users/Matt/Development/Terraform/terraform-aws-ec2-client-vpn/build-harness/vendor
curl --retry 3 --retry-delay 5 --fail -sSL -o /Users/Matt/Development/Terraform/terraform-aws-ec2-client-vpn/build-harness/vendor/gomplate https://github.com/hairyhenderson/gomplate/releases/download/v3.11.4/gomplate_darwin-amd64-slim && chmod +x /Users/Matt/Development/Terraform/terraform-aws-ec2-client-vpn/build-harness/vendor/gomplate
* Installing terraform-docs to /Users/Matt/Development/Terraform/terraform-aws-ec2-client-vpn/build-harness/vendor
mkdir -p -m a+rX /Users/Matt/Development/Terraform/terraform-aws-ec2-client-vpn/build-harness/vendor
[ -n "/tmp" ] && [ -n "terraform-docs" ] && rm -rf "/tmp/terraform-docs"
mkdir -p /tmp/terraform-docs
curl --retry 3 --retry-delay 5 --fail -sSL -o - https://github.com/segmentio/terraform-docs/releases/download/v0.16.0/terraform-docs-v0.16.0-darwin-amd64.tar.gz | tar -zx -C /tmp/terraform-docs
find /tmp/terraform-docs -type f -name terraform-docs | xargs -I {} cp -f {} /Users/Matt/Development/Terraform/terraform-aws-ec2-client-vpn/build-harness/vendor/terraform-docs
chmod +x /Users/Matt/Development/Terraform/terraform-aws-ec2-client-vpn/build-harness/vendor/terraform-docs
[ -n "/tmp" ] && [ -n "terraform-docs" ] && rm -rf "/tmp/terraform-docs"
make: gomplate: No such file or directory
make: *** [readme/build] Error 1
joe-niland commented 1 year ago

Hi @s1rc OK, no worries, please commit the other files and we'll try to do the readme using Github Actions.

s1rc commented 1 year ago

@joe-niland ok, I've pushed the changes from the first two commands.

joe-niland commented 1 year ago

/rebuild-readme

joe-niland commented 1 year ago

/test readme

joe-niland commented 1 year ago

/test all