search

cloudposse / terraform-aws-ec2-client-vpn

https://cloudposse.com/accelerate
Apache License 2.0
44 stars 27 forks source link

use for_each over count for iteration #96

Open jurgenweber opened 5 months ago

jurgenweber commented 5 months ago

what

moving to for_each for resources over count

why

I lost the ability to update an endpoint for 12 hours because of this. Standard terraform count vs for_each reasons (index changes with count).

references

https://github.com/cloudposse/terraform-aws-ec2-client-vpn/issues/30

jurgenweber commented 5 months ago

I am not on top of all of your processes, but this will be a breaking change because as per the issue you will trigger the AWS API problems.

Maybe we want a migration process? Maybe some moves? Let me know.

joe-niland commented 5 months ago

Hi @jurgenweber thanks for your contribution. Have you tested this code? It seems to have some invalid syntax.

jurgenweber commented 5 months ago

indeed, sorted now. Plans for me:

Plan: 36 to add, 0 to change, 36 to destroy.

:)

jurgenweber commented 2 months ago

Any reason this has been put on ice? What do you need from me to get it over the line?