cloudposse / terraform-aws-ec2-instance

Terraform module for provisioning a general purpose EC2 host
https://cloudposse.com/accelerate
Apache License 2.0
166 stars 220 forks source link

Added support for gp3 and io2 both root and ebs volumes (fixed copy of #117) #136

Closed tbpoetke closed 2 years ago

tbpoetke commented 2 years ago

what

why

references

nitrocode commented 2 years ago

/test all

nitrocode commented 2 years ago

@tbpoetke please bump modules in the examples in order to successfully pass the test/bats check

https://github.com/tbpoetke/terraform-aws-ec2-instance/blob/master/examples/complete/main.tf

tbpoetke commented 2 years ago

@tbpoetke please bump modules in the examples in order to successfully pass the test/bats check

https://github.com/tbpoetke/terraform-aws-ec2-instance/blob/master/examples/complete/main.tf @nitrocode Modules updated

nitrocode commented 2 years ago

@tbpoetke unfortunately after bumping the modules, there are also some breaking changes with the interface. Please ensure that the examples/complete module plans locally successfully and I will re-run tests.

tbpoetke commented 2 years ago

@tbpoetke unfortunately after bumping the modules, there are also some breaking changes with the interface. Please ensure that the examples/complete module plans locally successfully and I will re-run tests.

ok, I will try to fix it, thanks for your help!

tbpoetke commented 2 years ago

@nitrocode should work now, terraform validate and terraform plan no more errors, please retry the Github Action test. Thank you!

nitrocode commented 2 years ago

/test all

tbpoetke commented 2 years ago

Ok, will fix it again tomorrow ....sorry for the circumstances ...

nitrocode commented 2 years ago

/test all

nitrocode commented 2 years ago

@tbpoetke more yak shaving... please bump the required terraform version to > 1.0 in versions.tf and examples/complete/versions.tf

tbpoetke commented 2 years ago

It's a long ride through this pipeline :1234:

nitrocode commented 2 years ago

/test all

nitrocode commented 2 years ago

Thank you so much for the contribution @tbpoetke ! I know it was a bit arduous. Future PRs will be easier.

tbpoetke commented 2 years ago

Thank you for your review and your help @nitrocode . Next time I will try to test the pipeline with act to avoid such problems ....