cloudposse / terraform-aws-ec2-instance

Terraform module for provisioning a general purpose EC2 host
https://cloudposse.com/accelerate
Apache License 2.0
166 stars 220 forks source link

Correct how the volume_id is selected - Fix #165 #171

Closed it-praktyk closed 1 year ago

it-praktyk commented 1 year ago

what

Fix #165 - allows create an EC2 instance with additional volumes.

why

The issue was introduced here.

The one Terraform function returns an error, that blocks creating EC2 instances with additional (non-root) volumes.

references

closes #165

it-praktyk commented 1 year ago

Hi, I've checked the failed check. Fail is related to a CI process itself.

- Installing hashicorp/aws v5.12.0...
╷
│ Error: Failed to install provider
│ 
│ Error while installing hashicorp/aws v5.12.0: releases.hashicorp.com: Get
│ "https://releases.hashicorp.com/terraform-provider-aws/5.12.0/terraform-provider-aws_5.12.0_linux_amd64.zip":
│ read tcp 10.1.0.21:33138->13.33.21.37:443: read: connection reset by peer
╵

Error: Terraform exited with code 1.
Error: Process completed with exit code 1.

Can we proceed with a review even when the check failed?

joe-niland commented 1 year ago

/terratest

joe-niland commented 1 year ago

Thanks for your contribution @it-praktyk