search

cloudposse / terraform-aws-ecs-codepipeline

Terraform Module for CI/CD with AWS Code Pipeline and Code Build for ECS https://cloudposse.com/
https://cloudposse.com/accelerate
Apache License 2.0
155 stars 149 forks source link

Add build_type #103

Closed drselump14 closed 7 months ago

drselump14 commented 1 year ago

what

why

references

hans-d commented 8 months ago

/terratest

hans-d commented 8 months ago

@drselump14 Hi, can you update the pr so that it passes the tests? otherwise, it is likely to be closed due to staleness.

drselump14 commented 8 months ago

@hans-d Hi, I've rebased the branch with the master branch

hans-d commented 8 months ago

@drselump14 if you can take care of the failing readme test as well?

README.md is outdated. Please run the following commands locally and push the file:
  make init
  make readme
Error: Process completed with exit code 1.
hans-d commented 8 months ago

/terratest

drselump14 commented 8 months ago

/terratest

hans-d commented 8 months ago

/terratest

drselump14 commented 8 months ago

I added a PR https://github.com/cloudposse/terraform-aws-ecs-codepipeline/pull/123 to fix the failing terratest @hans-d

mergify[bot] commented 8 months ago

This pull request now has conflicts. Could you fix it @drselump14? 🙏

mergify[bot] commented 8 months ago

Thanks @drselump14 for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

mergify[bot] commented 7 months ago

This PR was closed due to inactivity and merge conflicts. 😭 Please resolve the conflicts and reopen if necessary.