cloudposse / terraform-aws-ecs-codepipeline

Terraform Module for CI/CD with AWS Code Pipeline and Code Build for ECS https://cloudposse.com/
https://cloudposse.com/accelerate
Apache License 2.0
154 stars 147 forks source link

feat: Adding pipeline type to module and provided a working example #129

Closed Roondel closed 3 months ago

Roondel commented 5 months ago

what

Adding pipeline_type to the module to set whether V1 or the newer V2 version is deployed.

why

This feature will allow for both github and bitbucket pipelines to de deployed as version 2.

references

https://docs.aws.amazon.com/codepipeline/latest/userguide/pipeline-types.html

joe-niland commented 3 months ago

Hi @Roondel I spoke to the team. Would you be able to add support for the other v2 features (trigger, variable, execution modes) and then we'll see what the best course of action is? Allowing v2 to be set doesn't have much effect otherwise.

I can help with changes/testing, as we use CodePipeline with our clients.