Module modernisation - Githubissues

cloudposse / terraform-aws-ecs-container-definition

Terraform module to generate well-formed JSON documents (container definitions) that are passed to the aws_ecs_task_definition Terraform resource

https://cloudposse.com/accelerate

Apache License 2.0

339 stars 244 forks source link

Module modernisation #102

Closed joe-niland closed 3 years ago

joe-niland commented 3 years ago

what

relax provider pinning
add chatops
add autorelease
use new terratest structure

why

Allow this module to be consumed by modules using later version of providers
Add gitops automation

references

closes #101

joe-niland commented 3 years ago

/test all

joe-niland commented 3 years ago

/test bats

joe-niland commented 3 years ago

/test terratest

joe-niland commented 3 years ago

/test readme

joe-niland commented 3 years ago

Hi @aknysh

I'll fix the example - missed that!

Regarding context, I did look at that but I ended up removing it because:

the environment variable conflicts
there is no label module usage

Let me know if I should add. I can at least change var.environment to use module.this.environment

jamengual commented 3 years ago

/rebuild-readme

jamengual commented 3 years ago

/test all

aknysh commented 3 years ago

Hi @aknysh

I'll fix the example - missed that!

Regarding context, I did look at that but I ended up removing it because:

the environment variable conflicts

there is no label module usage

Let me know if I should add. I can at least change var.environment to use module.this.environment

ah yes, this module is just a converter, no need for context.tf