Feat: Add `skip_destroy` Variable

cloudposse / terraform-aws-ecs-container-definition

Terraform module to generate well-formed JSON documents (container definitions) that are passed to the aws_ecs_task_definition Terraform resource

https://cloudposse.com/accelerate

Apache License 2.0

340 stars 245 forks source link

Closed cunymatthieu closed 2 years ago

cunymatthieu commented 2 years ago

Adding a skip_destroy variable

Very useful for deploying a new version of the ECS Task Definition without deleting the old one, especially in case of rollback

korenyoni commented 2 years ago

/test all

cunymatthieu commented 2 years ago

Ugh, I just realized that the parameter does not apply to the container definition, but to the Task Definition itself 😞 . I cancel my PR.

korenyoni commented 2 years ago

@cunymatthieu Ah okay — didn't even notice that in my quick glance of a review. Thanks for the submission regardless.