Closed obataku closed 1 year ago
@obataku can you get back to Nitro's requested changes and deal with the branch conflicts that you have? And if no longer relevant, feel free to close out. Thanks!
/terratest
@obataku Thanks for your contribution.
I merged your PR into the feature branch
to polish the code, fix conflicts and will merge it into the main
branch and cut new release
what
log_configuration
,repository_credentials
,system_controls
,container_definition
jsonencode
/jsondecode
cyclewhy
optional
obviateslookup(..., null)
calls for objectslookup(o, k)
without adefault
is deprecated in favor ofo[k]
or direct attr access (o.k
)log_configuration
,repository_credentials
, andsystem_controls
had needlessly opaqueany
types which hinder DX and make subtle bugs more likely (e.g. in the types oflog_configuration.options
values)container_definition
are now typed there's no reason not to type it as welllog_configuration
appropriately obviates explicittostring
&null
handling; resolves #151for
-expressions iterate over maps & objects by key in lexicographic orderjsonencode
-ing the final container definition only tojsondecode
forjson_map_object
is redundant