cloudposse / terraform-aws-ecs-container-definition

Terraform module to generate well-formed JSON documents (container definitions) that are passed to the aws_ecs_task_definition Terraform resource
https://cloudposse.com/accelerate
Apache License 2.0
339 stars 244 forks source link

Remove unused dependencies #156

Closed pguinard-public-com closed 1 year ago

pguinard-public-com commented 1 year ago

Describe the Bug

required_providers { local ... } is not required as locals are built into terraform. The local provider provides the following:

Expected Behavior

Not install a provider that is not required in order to speed up the terraform init process.

Steps to Reproduce

Sample terraform code

module "container_definition" {
  source  = "cloudposse/ecs-container-definition/aws"
  version = "0.58.1"

  container_name  = "app"
  container_image = "image:latest"
}
$ terraform providers

Providers required by configuration:
.
├── provider[registry.terraform.io/hashicorp/aws]
├── module.container_definition
│   └── provider[registry.terraform.io/hashicorp/local] >= 1.2.0

Screenshots

If applicable, add screenshots or logs to help explain your problem.

Environment (please complete the following information):

Anything that will help us triage the bug will help. Here are some ideas:

Additional Context

Add any other context about the problem here.