search

cloudposse / terraform-aws-ecs-container-definition

Terraform module to generate well-formed JSON documents (container definitions) that are passed to the aws_ecs_task_definition Terraform resource
https://cloudposse.com/accelerate
Apache License 2.0
340 stars 245 forks source link

Update portMappings to include containerPortRange #178

Closed asmithdt closed 5 months ago

asmithdt commented 9 months ago

what

Allow specifying containerPortRange in portMappings

why

To support containerPortRange

references

joe-niland commented 9 months ago

/terratest

aknysh commented 9 months ago

/terratest

joe-niland commented 9 months ago

Hi @asmithdt The tests will need updating to allow the Terratest check to pass. Are you happy to take a look?

asmithdt commented 8 months ago

Apologies, I missed these messages. I have made a change which I hope will resolve the tests, I can't seem to run locally to check though; not sure if that's something I need to setup with the build-harness? Let me know if that doesn't get it. Cheers!

mergify[bot] commented 6 months ago

💥 This pull request now has conflicts. Could you fix it @asmithdt? 🙏

mergify[bot] commented 6 months ago

This PR was closed due to inactivity and merge conflicts. 😭 Please resolve the conflicts and reopen if necessary.

YeomansIII commented 6 months ago

@asmithdt Anything I can do to help on this? Honestly not sure how to get containerPortRange to work in terraform at all, even though it supported on ECS. If anyone has any workarounds in the meantime, like having terraform forgo any validation of the container_definition (I can't think of another way to get containerPortRange into AWS...)

mergify[bot] commented 6 months ago

💥 This pull request now has conflicts. Could you fix it @asmithdt? 🙏

joe-niland commented 6 months ago

Hi @asmithdt

Sorry for the delay.

Could you please run the following and commit the result?

make init
make readme
mergify[bot] commented 5 months ago

This PR was closed due to inactivity and merge conflicts. 😭 Please resolve the conflicts and reopen if necessary.