search

cloudposse / terraform-aws-ecs-container-definition

Terraform module to generate well-formed JSON documents (container definitions) that are passed to the aws_ecs_task_definition Terraform resource
https://cloudposse.com/accelerate
Apache License 2.0
339 stars 244 forks source link

feat: :sparkles: added restart policies #192

Open JaydenMaalouf opened 1 week ago

JaydenMaalouf commented 1 week ago

what

Adds container restart policies to the container definition

why

This feature was introduced by AWS recently but has not made its way to this container

references

JaydenMaalouf commented 1 week ago 
make init
make readme

Seems init and readme are not valid Makefile targets in the root init appears to be valid int he test folder but no readme still Is there something I'm missing?

Gowiem commented 1 week ago

@JaydenMaalouf I wonder if you have a bad version of make? This line here adds the init target. Can you mess around with installing latest version of make on your machine and try again?

JaydenMaalouf commented 5 days ago

I wonder if you have a bad version of make?

Turns out the issue was running it on a Windows shell. Switched to WSL and reran make. Seemed to work!

goruha commented 4 days ago

@JaydenMaalouf could you pls add a description to this input https://github.com/cloudposse/terraform-aws-ecs-container-definition/blob/main/examples/complete/variables.tf#L1

I know that's not a part of the PR changes, but unfortunately, we test all terraform files and have such side effects. cc @Gowiem

mergify[bot] commented 3 days ago

💥 This pull request now has conflicts. Could you fix it @JaydenMaalouf? 🙏