search

cloudposse / terraform-aws-efs-backup

Terraform module designed to easily backup EFS filesystems to S3 using DataPipeline
https://cloudposse.com/accelerate
Apache License 2.0
43 stars 33 forks source link

Allow setting datapipeline security group #35

Closed plumdog closed 5 years ago

plumdog commented 5 years ago

The security group for the datapipeline instances opens SSH to the world (port 22, 0.0.0.0/0), which is not ideal.

Further, I had problems with it always showing changes (I think because I had modify_security_group = false and was adding a rule to the SG after the module had run).

This allows a security group to be passed into the module for use on the datapipeline instances. The EFS mount security group must allow traffic from this security group.

aknysh commented 5 years ago

@plumdog rebase

plumdog commented 5 years ago

@aknysh Rebased and readme rebuild.

plumdog commented 5 years ago

@aknysh Agreed and fixed.