search

cloudposse / terraform-aws-eks-cluster

Terraform module for provisioning an EKS cluster
https://cloudposse.com/accelerate
Apache License 2.0
506 stars 353 forks source link

Feature/update resolve conflicts #192

Closed tyu0912 closed 11 months ago

tyu0912 commented 1 year ago

what

Updating the addon to use resolve_conflicts_on_create and resolve_conflicts_on_update.

why

Per reference below, resolve_conflicts is deprecated.

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eks_addon

tyu0912 commented 1 year ago

@Gowiem / @korenyoni - is this PR helpful?

tyu0912 commented 11 months ago

@Gowiem @korenyoni?

Gowiem commented 11 months ago

@tyu0912 definitely helpful. Because this was an addition to the AWS provider API following a specific version of the provider, we'll need to ensure we bump the minimum version of the AWS provider as well. Can you track down that version and do that update in versions.tf?

Gowiem commented 11 months ago

/terratest

tyu0912 commented 11 months ago

Thanks @Gowiem . Done.

tyu0912 commented 11 months ago

/terratest

tyu0912 commented 11 months ago

Ah, that command doesn't work me. Will leave it to you guys then. Let me know if there's anything else.

Command 'terratest' is not configured for the user's permission level 'none'.

Gowiem commented 11 months ago

/terratest

Gowiem commented 11 months ago

@tyu0912 Please run the following commands and commit the changes

make init make github/init make readme

tyu0912 commented 11 months ago

@Gowiem , Done.

Gowiem commented 11 months ago

/terratest

Gowiem commented 11 months ago

@tyu0912 this looks good from my end, but because we're fixing a v5 deprecation and bumping the required provider to be v5 this would mean we should do a major version rev. I'm not sure if we actually want to do that at this time, so I am polling the rest of the contributor team to make sure that we're all on the same page before pulling the trigger here. I'll circle back here with a status update once we've discussed. Thanks for the patience!

tyu0912 commented 11 months ago

No problem. Thanks for all the help and putting this on the radar @Gowiem . My team and I are very much looking forward to this update and can understand the need for planning as well. Looking forward to the release when it happens. Let me know if there's anything else I can do to support.