cloudposse / terraform-aws-eks-cluster

Terraform module for provisioning an EKS cluster
https://cloudposse.com/accelerate
Apache License 2.0
513 stars 354 forks source link

feat: Add support bootstrap_self_managed_addons #236

Closed sergeyrudenko111 closed 2 months ago

sergeyrudenko111 commented 2 months ago

what

why

references

https://aws.amazon.com/about-aws/whats-new/2024/06/amazon-eks-cluster-creation-flexibility-networking-add-ons/

Gowiem commented 2 months ago

/terratest

Gowiem commented 2 months ago

@sergeyrudenko111 looks like you need to bump the minimum provider version:

│ Error: Unsupported argument
                            │ 
                            │   on main.tf line 115, in module "eks_cluster":
                            │  115:   bootstrap_self_managed_addons = var.bootstrap_self_managed_addons_enabled
                            │ 
                            │ An argument named "bootstrap_self_managed_addons" is not expected here.
sergeyrudenko111 commented 2 months ago

@Gowiem forgot to apply a variable name change from previous commit to examples/complete/main.tf, now terratest should pass.

Gowiem commented 2 months ago

/terratest

github-actions[bot] commented 2 months ago

These changes were released in v4.4.0.

Nuru commented 2 months ago

@Gowiem You were right, but our Terratests don't check for this.

AWS Provider version requirement needs to be bumped to v5.58.0