Update pet name when changing launch template id

cloudposse / terraform-aws-eks-node-group

Terraform module to provision a fully managed AWS EKS Node Group

https://cloudposse.com/accelerate

Apache License 2.0

91 stars 128 forks source link

Closed woz5999 closed 2 years ago

woz5999 commented 2 years ago

If you change the template id, tf/aws will try to create a new node group; however, because we're using create before destroy, it errors out due to "NodeGroup already exists with name food and cluster name bar"
generating a new pet name will restore the correct behavior
note that this was the behavior prior to Overhaul #84

woz5999 commented 2 years ago

/test all

woz5999 commented 2 years ago

@aknysh i ended up just creating a new fork since mine was so old. here's the fixed version of !105

woz5999 commented 2 years ago

anyone available to review this?

woz5999 commented 2 years ago

/test all

woz5999 commented 2 years ago

@aknysh @Nuru @Gowiem is anyone able to review this?

Gowiem commented 2 years ago

Since @Nuru did #84, I'll leave it to him.