ASG tags with "false" value cluster_autoscaler option

[eliasmachado21]

Describe the Bug

I'm trying to create a ASG without Cluster AutoScaler option enable

Expected Behavior

The ASG without tags for autodiscover CAS

Steps to Reproduce

Steps to reproduce the behavior:

1. Create a nodegroup with the option input_cluster_autoscaler_enabled in false value

Screenshots

ASG tags

Environment (please complete the following information):

Anything that will help us triage the bug will help. Here are some ideas:

• Module version "0.27.3"

[Gowiem]

@eliasmachado21 Great point and should be an easy fix! Would you be willing to put together a small PR to address by changing this line to have the value be assigned from local.autoscaler_enabled

[Nuru]

@eliasmachado21 Great point and should be an easy fix! Would you be willing to put together a small PR to address by changing this line to have the value be assigned from local.autoscaler_enabled

@Gowiem That is not a sufficient fix for a couple of reasons:

• The value of the tag key is typically ignored. The autoscaler just looks for the presence of the tag key.
• Those tags are already getting toggled: https://github.com/cloudposse/terraform-aws-eks-node-group/blob/8d415522042e8547caa31afb49d95bc640e32cf2/main.tf#L38

I don't know for sure where these tags are coming from, but they are standard tags and I strongly suspect they are getting created by the EKS cluster itself. See https://github.com/aws/containers-roadmap/issues/608#issuecomment-639549332

[Gowiem]

@Nuru Ah gotcha -- I didn't read deeply enough into how autoscaler_enabled is being used, apologies. Also didn't know the context around the value being ignored -- That is not great. Anyway, thanks on weighing in.