Update main.tf - Githubissues

cloudposse / terraform-aws-eks-node-group

Terraform module to provision a fully managed AWS EKS Node Group

https://cloudposse.com/accelerate

Apache License 2.0

91 stars 128 forks source link

Update main.tf #116

Closed surajrubik closed 2 years ago

surajrubik commented 2 years ago

Idea is to have the name in ec2 instance i.e is created by the autoscalling group.

what

Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
Use bullet points to be concise and to the point.

why

Provide the justifications for the changes (e.g. business case).
Describe why these changes were made (e.g. why do these commits fix the problem?)
Use bullet points to be concise and to the point.

references

Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
Use closes #123, if this PR closes a GitHub issue #123

Gowiem commented 2 years ago

/test all

Gowiem commented 2 years ago

@surajrubik I think I get what you're trying to do with this PR, but that is not how this should be accomplished.

We supply Name via module.label.tags which is the base of node_tags. This would override that and create an undesirable result.

Instead, you can pass the value of cluster_name into the tags input of the module as a new ClusterName tag and it will result in being applied to all resources. Can you please try that and let me know how it works for you? Until then, I'm going to close this out as I believe this would break other's existing tag structures erroneously. Thanks!

surajrubik commented 2 years ago

@Gowiem, did get you. I am not finding any variable to pass the same that you said, would help me to find it, please.

Gowiem commented 2 years ago

@surajrubik try this input to the module: https://github.com/cloudposse/terraform-aws-eks-node-group#input_tags