Conditionnaly disable default eks security group

cloudposse / terraform-aws-eks-node-group

Terraform module to provision a fully managed AWS EKS Node Group

https://cloudposse.com/accelerate

Apache License 2.0

90 stars 128 forks source link

Closed xeivieni closed 1 year ago

xeivieni commented 1 year ago

Add the possibility to remove association of the default eks security groups to the launch template

The default security group contains very wide rules (all ports inbound on itself)
Using the module it gets associated to all nodes by default
Certain use cases need to explicitly whitelist some of the traffic

xeivieni commented 1 year ago

Hi @florian0410 and @RothAndrew could you please review my PR ?

Gowiem commented 1 year ago

/test all

Gowiem commented 1 year ago

@xeivieni can you pull in the master branch and then we'll work on getting this merged?

xeivieni commented 1 year ago

I'm sorry @Gowiem I deleted my fork and the PR could not sync with the content of my recreated fork so I had to open an other PR here https://github.com/cloudposse/terraform-aws-eks-node-group/pull/141