cloudposse / terraform-aws-eks-node-group

Terraform module to provision a fully managed AWS EKS Node Group
https://cloudposse.com/accelerate
Apache License 2.0
91 stars 128 forks source link

fix: variable description for var.bootstrap_additional_options #144

Closed venkatamutyala closed 1 year ago

venkatamutyala commented 1 year ago

what

why

Should save someone time in the future when they try and find the variable as mentioned in the description.

aknysh commented 1 year ago

/test all

aknysh commented 1 year ago

@venkatamutyala thanks for the PR

please run the following commands from the root of the repo and commit the changes

make init
make github/init
make readme
venkatamutyala commented 1 year ago

@aknysh i think i did it correctly. Please let me know if you need anything else.

here is the full output from when I ran the commands:

@venkatamutyala ➜ /workspaces/FORK-terraform-aws-eks-node-group (fix/variable-description) $ make init
Cloning https://github.com/cloudposse/build-harness.git#master...
Cloning into 'build-harness'...
remote: Enumerating objects: 158, done.
remote: Counting objects: 100% (158/158), done.
remote: Compressing objects: 100% (128/128), done.
remote: Total 158 (delta 12), reused 97 (delta 8), pack-reused 0
Receiving objects: 100% (158/158), 101.88 KiB | 1.38 MiB/s, done.
Resolving deltas: 100% (12/12), done.
@venkatamutyala ➜ /workspaces/FORK-terraform-aws-eks-node-group (fix/variable-description) $ make github/init
# github/update: Updated .github/workflows/auto-context.yml
# github/update: Updated .github/mergify.yml
# github/update: Updated .github/renovate.json
curl -o context.tf -fsSL https://raw.githubusercontent.com/cloudposse/terraform-null-label/master/exports/context.tf
find . -xdev -mindepth 2 -name context.tf -exec cp -p context.tf {} \;
@venkatamutyala ➜ /workspaces/FORK-terraform-aws-eks-node-group (fix/variable-description) $ make readme
make[1]: Entering directory '/workspaces/FORK-terraform-aws-eks-node-group'
* Installing packages master...
Cloning into '/workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor/packages'...
remote: Enumerating objects: 926, done.
remote: Counting objects: 100% (926/926), done.
remote: Compressing objects: 100% (455/455), done.
remote: Total 926 (delta 320), reused 632 (delta 234), pack-reused 0
Receiving objects: 100% (926/926), 11.23 MiB | 10.71 MiB/s, done.
Resolving deltas: 100% (320/320), done.
make[1]: Leaving directory '/workspaces/FORK-terraform-aws-eks-node-group'
* Installing gomplate to /workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor
make[1]: Entering directory '/workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor/packages/install'
make[2]: Entering directory '/workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor/packages/vendor/gomplate'
mkdir -p -m a+rX /workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor
curl --retry 3 --retry-delay 5 --fail -sSL -o /workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor/gomplate https://github.com/hairyhenderson/gomplate/releases/download/v3.11.5/gomplate_linux-amd64 && chmod +x /workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor/gomplate
make[2]: Leaving directory '/workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor/packages/vendor/gomplate'
make[1]: Leaving directory '/workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor/packages/install'
make[1]: Entering directory '/workspaces/FORK-terraform-aws-eks-node-group'
make[1]: Leaving directory '/workspaces/FORK-terraform-aws-eks-node-group'
* Installing terraform-docs to /workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor
make[1]: Entering directory '/workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor/packages/install'
make[2]: Entering directory '/workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor/packages/vendor/terraform-docs'
mkdir -p -m a+rX /workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor
[ -n "/tmp" ] && [ -n "terraform-docs" ] && rm -rf "/tmp/terraform-docs"
mkdir -p /tmp/terraform-docs
curl --retry 3 --retry-delay 5 --fail -sSL -o - https://github.com/segmentio/terraform-docs/releases/download/v0.16.0/terraform-docs-v0.16.0-linux-amd64.tar.gz | tar -zx -C /tmp/terraform-docs
find /tmp/terraform-docs -type f -name terraform-docs | xargs -I {} cp -f {} /workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor/terraform-docs
chmod +x /workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor/terraform-docs
[ -n "/tmp" ] && [ -n "terraform-docs" ] && rm -rf "/tmp/terraform-docs"
make[2]: Leaving directory '/workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor/packages/vendor/terraform-docs'
make[1]: Leaving directory '/workspaces/FORK-terraform-aws-eks-node-group/build-harness/vendor/packages/install'
Generated README.md from /workspaces/FORK-terraform-aws-eks-node-group/build-harness/templates/README.md.gotmpl using data from /workspaces/FORK-terraform-aws-eks-node-group/build-harness/templates/README.yaml
aknysh commented 1 year ago

/test all