search

cloudposse / terraform-aws-eks-node-group

Terraform module to provision a fully managed AWS EKS Node Group
https://cloudposse.com/accelerate
Apache License 2.0
90 stars 128 forks source link

Made necessary changes for worker node AL2023 in version 1.0.1 #180

Closed Darsh8790 closed 3 months ago

Darsh8790 commented 4 months ago

what

Added changes for AL2023 worker node AMI based on version tag v1.0.0. ## why Currently, there are no changes for AL2023, even in the latest tag 2.12.0. The necessary modifications for AL2023 EKS worker nodes are not present. The existing EKS nodes running Amazon Linux 2 have multiple vulnerabilities. To remediate these issues, we need to upgrade our EKS worker nodes to AL2023 worker nodes. ## references We have tested these changes in our infrastructure, and they are working well. We request that these changes be merged and released as a new tag, 1.0.1, which will include all the updates up to tag 1.0.0, along with the changes for AL2023 worker nodes.
mergify[bot] commented 4 months ago

💥 This pull request now has conflicts. Could you fix it @Darsh8790? 🙏

mergify[bot] commented 4 months ago

[!IMPORTANT]

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

Nuru commented 4 months ago

@Darsh8790 Thank you for this PR.

I appreciate how much work you put into this. However, we cannot accept it as-is. If you do not want to work on it further, I understand, and we will use this to guide our future support for AL2023.

The main issue I see right off the bat is that this PR effectively breaks support for any AMI family other than AL2023. We would want to maintain backward compatibility for any AMIs Amazon continues to support.

Also, for this particular module, we are not supporting changes to v1. Although in general we want to allow for modifications for old major versions, this module's v1 was never really solid enough for that. So we would want these modifications to be made to the current version, which as of this writing is v2.12.0. (Note that even if we made the changes to v1, we would want to maintain support for older AMIs.)

Let us know how you'd like to proceed.

QuentinBtd commented 3 months ago

Working on https://github.com/cloudposse/terraform-aws-eks-node-group/pull/185 to add support of AL2023 with latest module version :)