cloudposse / terraform-aws-eks-node-group

Terraform module to provision a fully managed AWS EKS Node Group
https://cloudposse.com/accelerate
Apache License 2.0
90 stars 128 forks source link

feat: Add missed tags #191

Closed MaxymVlasov closed 1 month ago

MaxymVlasov commented 1 month ago

what

Add tags to resources where they missed

aknysh commented 1 month ago

/terratest

MaxymVlasov commented 1 month ago

@aknysh fixed

aknysh commented 1 month ago

Details

@MaxymVlasov please fix the errors

https://github.com/cloudposse/terraform-aws-eks-node-group/actions/runs/10305387428/job/28526252248?pr=191

not ok 1 check if terraform outputs have descriptions
not ok 1 check if terraform code needs formatting

in the main module and all the examples

thank you

MaxymVlasov commented 1 month ago

@aknysh try now

aknysh commented 1 month ago

@aknysh try now

@MaxymVlasov

the code is formatted, thanks.

but still this error

not ok 1 check if terraform outputs have descriptions

please check the outputs in the module AND in the examples.

thank you

MaxymVlasov commented 1 month ago

@aknysh it will be much more helpful if you use tflint checks, which point where issues are. Idk why Nuru did it in this way, but I added a description to it too

image

aknysh commented 1 month ago

/terratest

github-actions[bot] commented 1 month ago

These changes were released in v3.1.0.