search

cloudposse / terraform-aws-elastic-beanstalk-environment

Terraform module to provision an AWS Elastic Beanstalk Environment
https://cloudposse.com/accelerate
Apache License 2.0
304 stars 325 forks source link

Fix/security groups update #244

Closed samcrudge closed 1 year ago

samcrudge commented 1 year ago

what

Suggested changed by @goruha.

Default to empty string if aws_security_group.id is null. Empty string will then get filtered out by compact().

why

Null value caused sort() function to crash, making it impossible to set create_security_group to false

Implementing changes suggested in #229 by @goruha.

references

Fixed sort function crashing when create_security_group=false #229 Option create_security_group can't be false currently #216

joe-niland commented 1 year ago

/terratest

max-lobur commented 1 year ago

/terratest

joe-niland commented 1 year ago

Thanks for your contribution @samcrudge and @dawidrogowicz !

dawidrogowicz commented 1 year ago

cool, thanks for taking over :bow: