cloudposse / terraform-aws-elasticache-redis

Terraform module to provision an ElastiCache Redis Cluster
https://cloudposse.com/accelerate
Apache License 2.0
143 stars 247 forks source link

Adding engine_version to elasticache replication group arguments #12

Closed MoonMoon1919 closed 6 years ago

MoonMoon1919 commented 6 years ago

What it is

Adds engine_version argument to the aws_elasticache_replication_group module.

Why

Previously when referencing this module in an external terraform template any attempt to override the engine version was ignored because this option was unavailable. This resulted in AWS utilizing the default Redis engine (4.0), if attempting to make a cluster utilizing an older version of Redis (ex: 3.2.4) and referencing a parameter group using the family redis3.2 Terraform returns an error stating Error creating Elasticache Replication Group: InvalidParameterCombination: Expected a parameter group of family redis4.0 but found one of family redis3.2.

How I tested

Referenced this branch as the source of the module and used the variable engine_version to set to my desired engine version, spun up a cluster.

sarkis commented 6 years ago

Pushed https://github.com/cloudposse/terraform-aws-elasticache-redis/releases/tag/0.5.0

osterman commented 6 years ago

Thanks guys!