0.40.0 Missing arguments to pass existing security groups

cloudposse / terraform-aws-elasticache-redis

Terraform module to provision an ElastiCache Redis Cluster

https://cloudposse.com/accelerate

Apache License 2.0

141 stars 244 forks source link

0.40.0 Missing arguments to pass existing security groups #123

Closed z0rc closed 3 years ago

z0rc commented 3 years ago

https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/119 completely removed option to pass existing security groups to cluster, it just allows to create a new SG. Please revert this decision.

nitrocode commented 3 years ago

Please see comment https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/119#issuecomment-866229500

z0rc commented 3 years ago

Okay, it's called security_groups now. Why this kind of change happened in minor release is unexciting.

nitrocode commented 3 years ago

@z0rc This is all part of standardizing usage of the security group module across all of the cloudposse modules. We had similar growing pains with bringing context.tf. We'll work on our upgrade process more going forward. If you have suggestions, please let us know in our slack community.

If other issues come up, please file a new ticket.

Nuru commented 3 years ago

@z0rc We are taking feedback like yours into account and have marked v0.40.0 pre-release. We recommend using 0.39.0 for now and waiting for a later release which will provide better backward compatibility and clearer migration instructions.