fix: add suffix the parameter group

[syphernl]

what

• Added a generated suffix to the ElastiCache Redis Parameter Group name
• Added create_before_destroy ensuring a new PG is created before destroying the existing one

why

• Elasticache Redis Parameter Groups cannot modify their description without recreation. If a PG already existed, it could not be updated/replaced.
• The Parameter Group will automatically be recreated when the `description or the family changes

references

• Closes #142
• Relates to #143

[simoferr98]

Hi @syphernl I noticed this problem and I was about to open a new pull request.

The name of the resource aws_elasticache_parameter_group I would have indicated it like this:

name = "${module.this.id}-${random_id.redis_pg_name[0].hex}"

to keep the same name on the various resources.

Can you implement this change?

[syphernl]

Hi @syphernl I noticed this problem and I was about to open a new pull request.

The name of the resource aws_elasticache_parameter_group I would have indicated it like this:

name = "${module.this.id}-${random_id.redis_pg_name[0].hex}"

to keep the same name on the various resources.

Can you implement this change?

The prefix argument (docs) of the random_id resource should take care of that: https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/144/files#diff-dc46acf24afd63ef8c556b77c126ccc6e578bc87e3aa09a931f33d9bf2532fbbR101. The generated name should return something like myproject-stage-redis-hex, which would only change again in case the description or family does.

[simoferr98]

Hi @syphernl , Thanks for the clarification. I approve your changes

[mergify[bot]]

This pull request is now in conflict. Could you fix it @syphernl? 🙏

[nitrocode]

@syphernl is this still needed?

[syphernl]

No, we can close this one in favor of #143.