Re-adding tag propagation for cloudwatch alarms - Githubissues

cloudposse / terraform-aws-elasticache-redis

Terraform module to provision an ElastiCache Redis Cluster

https://cloudposse.com/accelerate

Apache License 2.0

141 stars 246 forks source link

Re-adding tag propagation for cloudwatch alarms #147

Closed brucehajdu closed 2 years ago

brucehajdu commented 2 years ago

what

In #7, the tag propagation was removed for CloudWatch metric alarms because the tags property did not exist at that time. This PR adds them back.

why

Terraform has had the capability to manage tags for aws_cloudwatch_metric_alarm resources for a while now, so I think we should add it back, as I think it makes sense for tags to propagate to all possible resources managed by the module.
This also helps me to comply with my organization's tagging policies without the hassle of manual intervention.

references

PR where the tags were removed: #7
Terraform docs showing tags as a valid option for metric alarms: aws_cloudwatch_metric_alarm
Closes https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/148

nitrocode commented 2 years ago

/test all