search

cloudposse / terraform-aws-elasticache-redis

Terraform module to provision an ElastiCache Redis Cluster
https://cloudposse.com/accelerate
Apache License 2.0
143 stars 247 forks source link

security_groups input description is slightly misleading #20

Closed kuritonasu closed 4 years ago

kuritonasu commented 6 years ago

The current description of the security_groups input is "AWS security group ids", which originally made me think that I should provide the module with pre-created security group ids. Since the module generates its own security groups, I believe that a more accurate description would be along the lines of "List of security group IDs to be allowed to connect to the cluster" (in line with your Elasticsearch's module secgroup input description)

Oh and thank you cloudposse people for the quality modules!

osterman commented 5 years ago

@kuritonasu thanks for the report. We'll get the documentation fixed.