cloudposse / terraform-aws-elasticache-redis

Terraform module to provision an ElastiCache Redis Cluster
https://cloudposse.com/accelerate
Apache License 2.0
141 stars 246 forks source link

feat: add support for redis serverless #227

Closed syphernl closed 4 weeks ago

syphernl commented 2 months ago

what

why

notes

mergify[bot] commented 2 months ago

[!IMPORTANT]

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

syphernl commented 2 months ago

Ready for review!

I have tested both example/complete and my new example/serverless and they both work.

syphernl commented 2 months ago

Some changes need to be made regarding the cache_usage_limits section, it's not working properly if these values are not provided causing the provider to break.

This issue in the AWS Provider is causing issues here: https://github.com/hashicorp/terraform-provider-aws/issues/36374

mergify[bot] commented 4 weeks ago

💥 This pull request now has conflicts. Could you fix it @syphernl? 🙏

mergify[bot] commented 4 weeks ago

This PR was closed due to inactivity and merge conflicts. 😭 Please resolve the conflicts and reopen if necessary.