search

cloudposse / terraform-aws-elasticache-redis

Terraform module to provision an ElastiCache Redis Cluster
https://cloudposse.com/accelerate
Apache License 2.0
141 stars 245 forks source link

security: add cidr_blocks as ingress option #41

Closed Richard-Mathie closed 4 years ago

Richard-Mathie commented 5 years ago

add cidr_blocks option to ingress for aws_security_group

karlskewes commented 4 years ago

Looks good, this would be useful for us as well.

The terraform-aws-rds-cluster module uses a different variable name: allowed_cidr_blocks allowed_cidr_blocks does appear in the eks module as well.

I see README.md might get updated via the make targets mentioned here: https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/50#pullrequestreview-307345284

Example: https://github.com/kskewes/terraform-aws-elasticache-redis/tree/allowed_cidr_blocks Happy to raise this as an alternate PR depending on your and the maintainers preference. Thanks for starting this!