search

cloudposse / terraform-aws-elasticache-redis

Terraform module to provision an ElastiCache Redis Cluster
https://cloudposse.com/accelerate
Apache License 2.0
141 stars 244 forks source link

Enable backups #45

Closed mazzy89 closed 5 years ago

mazzy89 commented 5 years ago

Signed-off-by: Salvatore Mazzarino apocalipse89@gmail.com

This gives the possibility to create enable automatic backups.

Could I also backport this change to a release before TF 0.12? So codebase that has not been migrated to TF would support this.

Thank you

aknysh commented 5 years ago

/codefresh run test

mazzy89 commented 5 years ago

@aknysh make sense I'll do it

mazzy89 commented 5 years ago

@aknysh Fixed

mazzy89 commented 5 years ago

/codefresh run test

aknysh commented 5 years ago

/codefresh run test

mazzy89 commented 5 years ago

sorry @aknysh. Fixed README.

aknysh commented 5 years ago

/codefresh run test

mazzy89 commented 5 years ago

@aknysh would it be possible to backport this change to a release prior of TF 0.12?

aknysh commented 5 years ago

for TF 0.11, open a PR against 0.11/master branch https://github.com/cloudposse/terraform-aws-elasticache-redis/tree/0.11/master

mazzy89 commented 5 years ago

Perfect. Thank you. I'm going to do it.