cloudposse / terraform-aws-elasticache-redis

Terraform module to provision an ElastiCache Redis Cluster
https://cloudposse.com/accelerate
Apache License 2.0
141 stars 244 forks source link

Remove unrelated Elasticsearch example #52

Closed karlskewes closed 4 years ago

karlskewes commented 4 years ago

I can't see a connection between this module and Elasticsearch. Please close if incorrect.

aknysh commented 4 years ago

/codefresh run test

aknysh commented 4 years ago

@kskewes thanks for the PR! please rebuild README

make init
make readme/deps
make readme

also please address this error which the latest version of TF 0.12 started to throw (our CI/CD is failing):

TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: Error: Error in function call                                                                                                  
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:                                                                                                                                
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:   on ../../outputs.tf line 17, in output "host":                                                                               
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:   17:   value = coalesce(                                                                                                      
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:   18:                                                                                                                          
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:   19:                                                                                                                          
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:   20:                                                                                                                          
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:   21:                                                                                                                          
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:   22:                                                                                                                          
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:   23:                                                                                                                          
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:     |----------------                                                                                                          
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:     | aws_elasticache_replication_group.default is empty tuple                                                                 
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:     | module.dns.hostname is ""                                                                                                
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:                                                                                                                                
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: Call to function "coalesce" failed: no non-null, non-empty-string arguments.                                                   

Should be similar to this:

https://github.com/cloudposse/terraform-aws-ec2-instance/pull/46/files#diff-c09d00f135e3672d079ff6e0556d957dR3

thanks

karlskewes commented 4 years ago

Thanks for quick review:

Secondly it also looks like the example fails due to lack of auth_token declaration.

aknysh commented 4 years ago

/codefresh run test

aknysh commented 4 years ago

/codefresh run test