Closed karlskewes closed 4 years ago
/codefresh run test
@kskewes thanks for the PR! please rebuild README
make init
make readme/deps
make readme
also please address this error which the latest version of TF 0.12 started to throw (our CI/CD is failing):
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: Error: Error in function call
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: on ../../outputs.tf line 17, in output "host":
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: 17: value = coalesce(
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: 18:
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: 19:
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: 20:
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: 21:
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: 22:
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: 23:
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: |----------------
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: | aws_elasticache_replication_group.default is empty tuple
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: | module.dns.hostname is ""
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121:
TestExamplesComplete 2019-11-18T22:44:14Z command.go:121: Call to function "coalesce" failed: no non-null, non-empty-string arguments.
Should be similar to this:
thanks
Thanks for quick review:
concat()
helper.Secondly it also looks like the example fails due to lack of auth_token
declaration.
transit_encryption
is enabled by default so auth_token
requiredauth_token
defaults to ""
but not overridden in fixtures
or main.tf
in example.
I can update the example to use random_string
per the README or to random_password
if preferable (see other PR #53) - please advise preference, thanks again. /codefresh run test
/codefresh run test
I can't see a connection between this module and Elasticsearch. Please close if incorrect.