restrict elasticache subnet group name to a max of 40 characters

cloudposse / terraform-aws-elasticache-redis

Terraform module to provision an ElastiCache Redis Cluster

https://cloudposse.com/accelerate

Apache License 2.0

141 stars 244 forks source link

restrict elasticache subnet group name to a max of 40 characters #57

Closed bcwilsondotcom closed 4 years ago

bcwilsondotcom commented 4 years ago

If the group name exceeds 40 characters the apply will fail. This will concat the string to be 40 characters or less.

aknysh commented 4 years ago

/codefresh run test

aknysh commented 4 years ago

/codefresh run test

aknysh commented 4 years ago

@DevBOFH Thanks for the PR, it looks good. Just one issue:

DevBOFH wants to merge 1 commit into cloudposse:master from unknown repository

What repo are you using? It says from unknown repository, and the issue is we can't run the automated tests because it also can't get the code from your repo and fails:

Command [git checkout $REVISION] exited with code [128]                                                                                                                                  
[SYSTEM]                                                                                                                                                                                 
 Message             Failed to run git-clone step: Clone repository

Can you please take a look at that?

maximmi commented 4 years ago

@DevBOFH Thank you for the contribution! Our positions is that we should not alter the behaviour because it will introduce the new problems and provide no guarantees of unique resource names. We should not mask issues.