cloudposse / terraform-aws-elasticache-redis

Terraform module to provision an ElastiCache Redis Cluster
https://cloudposse.com/accelerate
Apache License 2.0
141 stars 244 forks source link

fix alarm metric dimension CacheClusterId #62

Closed chelomontilla closed 3 years ago

chelomontilla commented 4 years ago

what

why

references

chelomontilla commented 4 years ago

@maximmi I did an aws elasticache describe-cache-clusters and the output doesn't display any CacheNodeId. Here the output:

{
   "CacheClusterId":"my-cluster-cache-001",
   "ReplicationGroupId":"my-cluster-cache",
   "CacheClusterStatus":"available",
   "SnapshotRetentionLimit":0,
   "ClientDownloadLandingPage":"https://console.aws.amazon.com/elasticache/home#client-download:",
   "PendingModifiedValues":{

   },
   "Engine":"redis",
   "CacheSecurityGroups":[

   ],
   "NumCacheNodes":1,
   "AuthTokenLastModifiedDate":"2020-02-24T08:35:42.379Z",
   "AutoMinorVersionUpgrade":true,
   "TransitEncryptionEnabled":true,
   "SecurityGroups":[
      {
         "Status":"active",
         "SecurityGroupId":"sg-xxxxxxxx"
      }
   ],
   "CacheNodeType":"cache.t2.small",
   "PreferredMaintenanceWindow":"wed:03:00-wed:04:00",
   "CacheSubnetGroupName":"my-cluster-cache",
   "AuthTokenEnabled":true,
   "AtRestEncryptionEnabled":false,
   "EngineVersion":"5.0.6",
   "CacheClusterCreateTime":"2020-01-15T11:55:02.665Z",
   "PreferredAvailabilityZone":"eu-west-1a",
   "SnapshotWindow":"06:30-07:30",
   "NotificationConfiguration":{
      "TopicStatus":"active",
      "TopicArn":"arn:aws:sns:eu-west-1:xxxxxxxxxxx:xxxxxxxxxxxxxxxxxxx"
   },
   "CacheParameterGroup":{
      "CacheNodeIdsToReboot":[

      ],
      "CacheParameterGroupName":"my-cluster-cache",
      "ParameterApplyStatus":"in-sync"
   }
}
osterman commented 4 years ago

/test all

jamengual commented 3 years ago

/test all

jamengual commented 3 years ago

/rebuild-readme

jamengual commented 3 years ago

@chelomontilla can you rebase from master, please?

mergify[bot] commented 3 years ago

This pull request is now in conflict. Could you fix it @chelomontilla? 🙏

nitrocode commented 3 years ago

Looks like this was fixed by a previous PR.