add and document variable for missing data in alarms

cloudposse / terraform-aws-elasticache-redis

Terraform module to provision an ElastiCache Redis Cluster

https://cloudposse.com/accelerate

Apache License 2.0

141 stars 244 forks source link

Closed chrischildresssg closed 3 years ago

chrischildresssg commented 4 years ago

Without this functionality, alarms created with this module may show up as "insufficient data" and act as such, neither being in "alarm" or "ok" state.

jamengual commented 4 years ago

@chrischildresssg could you rebase from master plase? thanks

osterman commented 4 years ago

/rebuild-readme

chrischildresssg commented 4 years ago

@chrischildresssg could you rebase from master plase? thanks

I apologize; I'm not sure what you want.

jamengual commented 4 years ago

There is conflicts that need to get fixed @chrischildresssg if you pull from master and solve the conflicts we will be able to run tests

aknysh commented 3 years ago

@chrischildresssg please rebase

jamengual commented 3 years ago

@chrischildresssg could please fix the conflict ?

mergify[bot] commented 3 years ago

This pull request is now in conflict. Could you fix it @chrischildresssg? 🙏

jamengual commented 3 years ago

@chrischildresssg is this still relevant?

chrischildresssg commented 3 years ago

I'm going to close this PR; I do not believe it is still necessary. I apologize if there have been any issues caused by it.