search

cloudposse / terraform-aws-elasticache-redis

Terraform module to provision an ElastiCache Redis Cluster
https://cloudposse.com/accelerate
Apache License 2.0
141 stars 244 forks source link

do not limit to only v2, ensure we go to v3 of the aws provider which… #80

Closed jurgenweber closed 4 years ago

jurgenweber commented 4 years ago

… has more tf 13 fixes

what

do not restrict the aws provider version to just v2

why

https://github.com/cloudposse/terraform-aws-route53-cluster-hostname/issues/23 the aws cloud provider has v13 fixes and requirements also

references

closes #79 https://github.com/cloudposse/terraform-aws-elasticache-redis/issues/79

jurgenweber commented 4 years ago

I have gone with the suggestions made by @aknysh here: https://github.com/cloudposse/terraform-aws-dynamodb/pull/62#discussion_r480600230

woz5999 commented 4 years ago

i think this PR can be closed. minimum version pinning was merged in #81 and the recommended best practice from hashicorp is to exclude introducing a max version in individual modules