search

cloudposse / terraform-aws-elasticache-redis

Terraform module to provision an ElastiCache Redis Cluster
https://cloudposse.com/accelerate
Apache License 2.0
141 stars 244 forks source link

Use name_prefix and create_before_destroy on security groups #86

Closed ac-hibbert closed 2 years ago

ac-hibbert commented 3 years ago

Found a bug? Maybe our Slack Community can help.

Slack Community

Describe the Bug

It can be a pain when the security group name changes as it would not be able to destroy - potentially using this pattern would work - https://github.com/terraform-aws-modules/terraform-aws-security-group/blob/master/main.tf#L34

Expected Behavior

Able to create new security group and assign it prior to destroy

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Run '....'
  3. Enter '....'
  4. See error

Screenshots

If applicable, add screenshots or logs to help explain your problem.

Environment (please complete the following information):

Anything that will help us triage the bug will help. Here are some ideas:

Additional Context

Add any other context about the problem here.

wszychta commented 3 years ago

I have created PR which is fixing this issue.

wszychta commented 3 years ago

Any updates on this issue?

wszychta commented 3 years ago

@ac-hibbert There is new version of the plugin 0.40.0. I'm using it instead of my fork to solve this issue.

Nuru commented 3 years ago

This will be fixed in the next release