search

cloudposse / terraform-aws-elasticsearch

Terraform module to provision an Elasticsearch cluster with built-in integrations with Kibana and Logstash.
https://cloudposse.com/accelerate
Apache License 2.0
216 stars 231 forks source link

Add dynamic block for log_publishing_options #103

Closed JoostSaanen closed 6 months ago

JoostSaanen commented 3 years ago

what

Module doesn't work with older ES versions (tested with 1.5 and 2.3) log_publishing_options is not supported in older versions Error creating ElasticSearch domain: InvalidTypeException: Application Logs option cannot be specified for ElasticSearch version : 1.5 & 2.3

references

nitrocode commented 3 years ago

@JoostSaanen could you fix the auto format issues. Normally the bot user would be able to do this but because the fork doesnt have give the cloudpossebot access, it needs to be done manually. I believe you can do it using

make init && make readme
nitrocode commented 3 years ago

/test all

Gowiem commented 2 years ago

@JoostSaanen please @nitrocode's comment regarding rebuilding the readme. We'll need that to be done to move this PR forward. Thank you!

JoostSaanen commented 2 years ago

Ouch, missed this one. I'll have a look

goruha commented 1 year ago

/test all

goruha commented 1 year ago

@JoostSaanen Could you pls rebase the lastest changes from the master branch? There are a few fixes for tests.

Thanks.

mergify[bot] commented 6 months ago

This pull request is now in conflict. Could you fix it @JoostSaanen? 🙏

mergify[bot] commented 6 months ago

This PR has been closed due to inactivity and merge conflicts. Please resolve the conflicts and reopen if necessary.

mergify[bot] commented 6 months ago

Thanks @JoostSaanen for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

sepulworld commented 3 months ago

@cloudposse-mergebot reopen please. this is an issue for me. This fix works