cloudposse / terraform-aws-elasticsearch

Terraform module to provision an Elasticsearch cluster with built-in integrations with Kibana and Logstash.
https://cloudposse.com/accelerate
Apache License 2.0
218 stars 231 forks source link

label_value_case, label_key_case and id_length_limit are set to incorrect values by default failing validations #108

Open anon892 opened 3 years ago

anon892 commented 3 years ago

Describe the Bug

Terraform 13 allows for validation block inside variables and the variables values for label_value_case, label_key_case and id_length_limit are set to incorrect values by default, which is failing validation. This also conflicts with the information present in the README where the default values mentioned and set are incorrect.

Expected Behavior

The Expected behavior is that the README should reflect the default value correctly and the code should be updated accordingly so that we don't get validation errors.

Steps to Reproduce

Steps to reproduce the behavior: Pull in the latest code from the module and run it. The validation for the above variables fail and it gives errors like below:

Error: Custom variable validation is experimental on .terraform/modules/es6.es/context.tf line 71, in variable "context": 71: validation { This feature is currently an opt-in experiment, subject to change in future releases based on feedback. Activate the feature for this module by adding variable_validation to the list of active experiments. Error: Custom variable validation is experimental on .terraform/modules/es6.es/context.tf line 167, in variable "id_length_limit": 167: validation { This feature is currently an opt-in experiment, subject to change in future releases based on feedback. Activate the feature for this module by adding variable_validation to the list of active experiments. Error: Custom variable validation is experimental on .terraform/modules/es6.es/context.tf line 182, in variable "label_key_case": 182: validation { This feature is currently an opt-in experiment, subject to change in future releases based on feedback. Activate the feature for this module by adding variable_validation to the list of active experiments. Error: Custom variable validation is experimental on .terraform/modules/es6.es/context.tf line 197, in variable "label_value_case": 197: validation { This feature is currently an opt-in experiment, subject to change in future releases based on feedback. Activate the feature for this module by adding variable_validation to the list of active experiments.