Closed dm3ch closed 1 year ago
/test all
@dm3ch we can not run tests for this PR at the moment.
Can you pull the latest changes from the master
branch with the fix for tests?
@goruha Merged current master
/test all
@dm3ch now this PR duplicates PR https://github.com/cloudposse/terraform-aws-elasticsearch/pull/149 The PR contains issues that break our tests.
Can you leave in the PR only code related to cold storage support
Thanks.
@goruha Yep, merged the wrong branch.
Now dropped unwanted changes from this PR.
/test all
@goruha I'm not sure how to better fix this test.
I even don't understand why the test tries to enable cold storage if I haven't modified any tests and made it disabled by default.
@dm3ch it does not enable cold storage. I says that it do not support that cold storage configuration block at all
Error: creating Elasticsearch Domain (eg-test-es-test-10332): ValidationException: Your domain's Elasticsearch version does not support cold storage options. Upgrade to Elasticsearch 7.9 or later.
I think you have to make this block dynamic
Ok, wrapped to dynamic block
/test all
@dm3ch LGTM
Thanks for your contribution.
what
cluster_config.cold_storage_options.enabled
why