Parameterize access policies json for more flexibility

cloudposse / terraform-aws-elasticsearch

Terraform module to provision an Elasticsearch cluster with built-in integrations with Kibana and Logstash.

https://cloudposse.com/accelerate

Apache License 2.0

218 stars 231 forks source link

Parameterize access policies json for more flexibility #155

Closed bmbferreira closed 9 months ago

bmbferreira commented 1 year ago

what

Adds a new parameter to be able to pass a json string with a custom access policy to set for the elasticsearch.

why

In my opinion, the access policies are too "opinionated" on this module, especially when it is on "vpc mode". I think it should be more flexible and allow to customize it however we want and not having it based on the iam_role_arn variable.

references

N/A

bmbferreira commented 11 months ago

Hi @srhopkins @woz5999! Any chance this can get reviewed? Or should I close the Pull Request? Thank you.

mergify[bot] commented 9 months ago

This pull request is now in conflict. Could you fix it @bmbferreira? 🙏

mergify[bot] commented 9 months ago

This PR has been closed due to inactivity and merge conflicts. Please resolve the conflicts and reopen if necessary.

mergify[bot] commented 9 months ago

Thanks @bmbferreira for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.