Add var.create_elasticsearch_user_role

[mohamed-essam]

what

• Add variable to control creation of aws_iam_role.elasticsearch_user

why

• Resource not needed and can cause compliance issues

references

closes #160

[aknysh]

@mohamed-essam thanks for the PR. Please make a few changes:

1. The resource data "aws_iam_policy_document" "assume_role" in https://github.com/cloudposse/terraform-aws-elasticsearch/blob/master/main.tf#L84 is only needed if we create resource "aws_iam_role" "elasticsearch_user". Please add the same logic in the count as you added for resource "aws_iam_role" "elasticsearch_user"

2. In https://github.com/cloudposse/terraform-aws-elasticsearch/blob/master/main.tf#L258, change it to

identifiers = distinct(compact(concat(var.iam_role_arns, aws_iam_role.elasticsearch_user[*].arn)))

to use the splat expression https://developer.hashicorp.com/terraform/language/expressions/splat

3. Please run the following commands from the root of the repo and commit the changes:

make init
make github/init
make readme

Thank you

[mohamed-essam]

@aknysh I couldn't find exact documentation on the steps required for contribution (I saw make readme in a comment in README.md), would it be possible to add these steps in a CONTRIBUTING.md file or in the README?

[aknysh]

nice point, we should add it, thanks

[aknysh]

/test all