search

cloudposse / terraform-aws-elasticsearch

Terraform module to provision an Elasticsearch cluster with built-in integrations with Kibana and Logstash.
https://cloudposse.com/accelerate
Apache License 2.0
218 stars 231 forks source link

Adds AWS EC2 Service Name to service. #61

Closed antoniocanelas closed 4 years ago

antoniocanelas commented 4 years ago

what

why

Insert aws ec2 service identifier different than ["ec2.amazonaws.com"] is necessary, for example in china accounts we need ["ec2.amazonaws.com.cn"].

osterman commented 4 years ago

/test all

3h4x commented 4 years ago

/test all

antoniocanelas commented 4 years ago

Hi, the changes requested in the code review are done. Also all checks have passed. Should I have to do something more in order to merge this feature?

Thank you, regards.

3h4x commented 4 years ago

Hi, the changes requested in the code review are done. Also all checks have passed. Should I have to do something more in order to merge this feature?

Thank you, regards.

No, nothing on your side. I will merge it and release today.

3h4x commented 4 years ago

@antoniocanelas And it's released 🎉 https://github.com/cloudposse/terraform-aws-elasticsearch/releases/tag/0.18.0