search

cloudposse / terraform-aws-firewall-manager

Terraform module to configure AWS Firewall Manager
https://cloudposse.com/accelerate
Apache License 2.0
17 stars 22 forks source link

fix logging configuration when enabled and disabled #32

Open gpetras opened 1 year ago

gpetras commented 1 year ago

This fixes issue #31

what

The Firewall Manager logging configuration would not enable whether or not I supplied my own Kinesis Firehose or not. I tried to turn on firehose_enabled, and I also tried to supply a Firehose ARN using firehose_arn, which I understand conflict with each other when used at the same time. This issue is fixed

I also simplified the logic for generating the logging configuration, as I found it difficult to troubleshoot the multiple nested ternaries.

why

Fixes the logging configuration so that it properly logs to Kinesis Firehose w/ S3

references

closes #31

hans-d commented 8 months ago

/terratest

hans-d commented 8 months ago

@gpetras Hi, can you update the pr so that it passes the tests? otherwise, it is likely to be closed due to staleness.

mergify[bot] commented 8 months ago

Thanks @gpetras for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

hans-d commented 8 months ago

/terratest