cloudposse / terraform-aws-lambda-function

A module for launching Lambda Fuctions
https://cloudposse.com/accelerate
Apache License 2.0
30 stars 40 forks source link

Add ephemeral storage size option #31

Closed drselump14 closed 1 year ago

drselump14 commented 1 year ago

What

Why

Gowiem commented 1 year ago

/test all

Gowiem commented 1 year ago

/test all

max-lobur commented 1 year ago

/test all

@Gowiem /terratest is the new command, it does only terratest, everything else is automatic per-commit

max-lobur commented 1 year ago

Please rebase on main, or just delete the .github/workflows/validate-codeowners.yml - it was removed from main.

drselump14 commented 1 year ago

done!

max-lobur commented 1 year ago

done!

Thanks! tflint has found that variable event_source_mappings is unused, would you mind removing it? Also when you done please run the

  make init
  make readme
drselump14 commented 1 year ago

done!

Thanks! tflint has found that variable event_source_mappings is unused, would you mind removing it? Also when you done please run the

  make init
  make readme
* this will get your docs up to date

Done. I removed other variables that is no longer used too

max-lobur commented 1 year ago

Thanks for the cleanup!

max-lobur commented 1 year ago

/terratest

manifestori commented 1 year ago

This looks great, whats holding us back?

manifestori commented 1 year ago

event_source_mappings was supposed to be used; why remove it? how can one pass triggers to lambda...

drselump14 commented 1 year ago

event_source_mappings was supposed to be used; why remove it? how can one pass triggers to lambda...

Hi, not sure buf tflint complaints about the variable not being used, and I can't find any reference to this variable outside the variable.tf file