add image_uri to ignore_changes if ignore_external_function_updates is true

cloudposse / terraform-aws-lambda-function

A module for launching Lambda Fuctions

https://cloudposse.com/accelerate

Apache License 2.0

30 stars 40 forks source link

add image_uri to ignore_changes if ignore_external_function_updates is true #32

Closed apachunuri-blink closed 6 months ago

apachunuri-blink commented 1 year ago

what

Looks like ignore_external_function_updates property although exposed as an input variable isnt implemented.

why

Input variable input_ignore_external_function_updates doesnt do what it's expected to do
This commit adds image_uri to the list of properties to ignore while detecting changes for tf plan/apply.

references

Gowiem commented 11 months ago

@apachunuri-blink friendly ping on this PR -- I would love to see this work get done. Would you be able to get back to it?

mergify[bot] commented 6 months ago

This pull request is now in conflict. Could you fix it @apachunuri-blink? 🙏

mergify[bot] commented 6 months ago

This PR has been closed due to inactivity and merge conflicts. Please resolve the conflicts and reopen if necessary.

mergify[bot] commented 6 months ago

Thanks @apachunuri-blink for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

[!TIP]

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

mergify[bot] commented 6 months ago

[!IMPORTANT]

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.